templates/show_event: Add fedora-coreos-tracker as bug source #40

Closed

c4rt0 wants to merge 1 commit from PR/check_bug_source into develop

c4rt0 commented

2025-03-28 21:54:36 +00:00

First-time contributor

During the F42 CoreOS test days it appeared that issues linked
in comments incorrectly redirect users to bugzila issues with
same numbers. This modification fixes this issue.

See: https://pagure.io/fedora-qa/testdays-web/issue/39

During the F42 CoreOS test days it appeared that issues linked in comments incorrectly redirect users to bugzila issues with same numbers. This modification fixes this issue. See: https://pagure.io/fedora-qa/testdays-web/issue/39

lbrabec commented

2025-03-28 23:01:11 +00:00

Contributor

Your change doesn't work properly.

bug is expected to be a number and it is enforced by validators in https://pagure.io/fedora-qa/testdays-web/blob/develop/f/testdays/lib/forms.py . Entering number into bug field will result in Unknown URL format: 123456.

If I disable the validators your change doesn't work properly either, if I enter https://bugzilla.redhat.com/show_bug.cgi?id=2351026 to bug field it creates a link to https://bugzilla.redhat.com/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=2351026 which obviously doesn't work.

Your change doesn't work properly. `bug` is expected to be a number and it is enforced by validators in https://pagure.io/fedora-qa/testdays-web/blob/develop/f/testdays/lib/forms.py . Entering number into bug field will result in `Unknown URL format: 123456`. If I disable the validators your change doesn't work properly either, if I enter `https://bugzilla.redhat.com/show_bug.cgi?id=2351026` to bug field it creates a link to `https://bugzilla.redhat.com/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=2351026` which obviously doesn't work.

jskladan commented

2025-04-04 08:20:12 +00:00

Contributor

@c4rt0 Sorry, but this just plain does not work, you completely ignored the backend...

While I'm not against allowing bugs to be taken from other trackers (makes sense now, please understand that when this code was created, we only used BZ...), I want this done in a more feasible way:

change the Input to TextField
enforce one-link-per-line
validate the URLs (have a look at wtforms.validators.URL even though it can not be used directly in this situation) and pointing to a curated subset of TLDs (I'd start with redhat, pagure, github, gitlab, gitea, maybe some more)

Also note, that I'll be pushing a complete rewrite of this 12-years-old codebase, but if you make acceptable PR, within the lines I shown, for current master, backporting (forwardporting) it to the new one will be very easy.

@c4rt0 Sorry, but this just plain does not work, you completely ignored the backend... While I'm not against allowing bugs to be taken from other trackers (makes sense now, please understand that when this code was created, we only used BZ...), I want this done in a more feasible way: - change the Input to TextField - enforce one-link-per-line - validate the URLs (have a look at wtforms.validators.URL even though it can not be used directly in this situation) and pointing to a curated subset of TLDs (I'd start with redhat, pagure, github, gitlab, gitea, maybe some more) Also note, that I'll be pushing a complete rewrite of this 12-years-old codebase, but if you make acceptable PR, within the lines I shown, for current master, backporting (forwardporting) it to the new one will be very easy.

jskladan commented

2025-04-04 11:15:33 +00:00

Contributor

Anyway, thank you for reporting the issue, and trying to come up with a solution. This will be fixed in the new release!