quality/testdays-web
5
0
Fork 0
Code Issues 16 Pull requests Projects Releases Packages Wiki Activity Actions

Replace werkzeug SimpleCache by flask-caching #13

Merged
kparal merged 1 commit from werkzeug_1_0 into develop 2020-07-24 17:39:19 +00:00
Conversation 7 Commits 1 Files changed 3 +5 -4
frantisekz commented 2020-07-23 14:25:40 +00:00
Contributor
Copy link
No description provided.
jskladan commented 2020-07-24 05:48:44 +00:00
Contributor
Copy link

IMO you should set cache type to simple, since the default is nullcache https://pythonhosted.org/Flask-Caching/#configuring-flask-caching https://pythonhosted.org/Flask-Caching/#nullcache

IMO you should set cache type to simple, since the default is nullcache https://pythonhosted.org/Flask-Caching/#configuring-flask-caching https://pythonhosted.org/Flask-Caching/#nullcache
jskladan commented 2020-07-24 05:53:58 +00:00
Contributor
Copy link

Also, the flask-caching Cache needs to be set with an app object (https://pythonhosted.org/Flask-Cache/#set-up) Looks to me like you either are running some weird code, that is not really flask-caching, or you forgot to try and run/test the code after you made the changes ;)

Also, the flask-caching Cache needs to be set with an app object (https://pythonhosted.org/Flask-Cache/#set-up) Looks to me like you either are running some weird code, that is not really flask-caching, or you forgot to try and run/test the code after you made the changes ;)
jskladan commented 2020-07-24 05:59:08 +00:00
Contributor
Copy link

I just noticed the "not tested yet" comment. I'd appreciate if you used "WIP" or something like that right in the PR's title, next time, like you do in Oraculum, for example, so I don't need to get into the "how the hell can this work for him" rabbit hole :)

I just noticed the "not tested yet" comment. I'd appreciate if you used "WIP" or something like that right in the PR's title, next time, like you do in Oraculum, for example, so I don't need to get into the "how the hell can this work for him" rabbit hole :)
frantisekz commented 2020-07-24 07:13:38 +00:00
Author
Contributor
Copy link

rebased onto b837055c82

rebased onto b837055c82a009ef7e79bf03587c0d0e9833b07e
frantisekz commented 2020-07-24 07:14:57 +00:00
Author
Contributor
Copy link

I've fixed this mess, really sorry for not properly marking it as WIP.

It seems it works as it should now, data gets loaded from cache and there are no fires to put out.

I've fixed this mess, really sorry for not properly marking it as WIP. It seems it works as it should now, data gets loaded from cache and there are no fires to put out.
jskladan commented 2020-07-24 15:03:29 +00:00
Contributor
Copy link

👍 thanks! LGTM

:thumbsup: thanks! LGTM
frantisekz commented 2020-07-24 17:39:19 +00:00
Author
Contributor
Copy link

Pull-Request has been merged by frantisekz

Pull-Request has been merged by frantisekz
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
  
Closed As
Duplicate
Closed with the reason of Duplicate

  
Closed As
Fixed
Closed with the reason of Fixed

  
Closed As
Invalid
Closed with the reason of Invalid

  
easyfix

   
enhancement
  
Priority
Critical
Priority of Critical

  
Priority
High
Priority of High

  
Priority
Low
Priority of Low

  
Priority
Normal
Priority of Normal

  
Backlog Status
Needs Review
Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore

Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation

Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt

Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
bug
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
easyfix
enhancement
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/testdays-web!13
No description provided.